Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more connection executor tests (native types, select data, cast for output, etc.) #8

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Add more connection executor tests (native types, select data, cast for output, etc.) #8

merged 3 commits into from
Oct 10, 2023

Conversation

KonstantAnxiety
Copy link
Contributor

No description provided.

@KonstantAnxiety KonstantAnxiety changed the title Add more connection executor tests Add more connection executor tests (native types, select data, cast for output, etc.) Oct 10, 2023
MCPN
MCPN requested changes Oct 10, 2023
View reviewed changes
lib/dl_api_lib_testing/dl_api_lib_testing/connector/complex_queries.py Show resolved Hide resolved
lib/dl_connector_postgresql/dl_connector_postgresql_tests/db/core/test_connection_executor.py Outdated
sync_connection_executor: SyncConnExecutorBase,
enabled_citext_extension,
) -> None:
super().test_type_recognition(request, db, sync_connection_executor)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the idea is to invoke the enabled_citext_extension fixture, you can try @pytest.mark.usefixtures

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and now you can decorate the whole class and remove the redefinition)

MCPN
MCPN requested changes Oct 10, 2023
View reviewed changes
lib/dl_connector_postgresql/dl_connector_postgresql_tests/db/core/test_connection_executor.py Outdated
sync_connection_executor: SyncConnExecutorBase,
enabled_citext_extension,
) -> None:
super().test_type_recognition(request, db, sync_connection_executor)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and now you can decorate the whole class and remove the redefinition)

@KonstantAnxiety KonstantAnxiety merged commit 7482ce0 into main Oct 10, 2023
16 of 29 checks passed
@KonstantAnxiety KonstantAnxiety deleted the ce-tests branch October 10, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MCPN MCPN MCPN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KonstantAnxiety @MCPN